Fixed Invalid index used in Debug logs #3923
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeevan-vj
requested review from
bruno-garcia and
jamescrosswell
as code owners
bruno-garcia
approved these changes
Jan 29, 2025
|
Thank you for this! We definitely need an analyzer for this because it can cause a crash |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3923 +/- ##
==========================================
+ Coverage 75.73% 76.53% +0.80%
==========================================
Files 357 389 +32
Lines 13466 14228 +762
Branches 2671 2864 +193
==========================================
+ Hits 10198 10890 +692
- Misses 2593 2639 +46
- Partials 675 699 +24 ☔ View full report in Codecov by Sentry. |
|
Thank you @bruno-garcia . +1 for the code analyzer to catch these types of issues beforehand. |
jamescrosswell
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3922
Changes
Corrected the parameter index in the
LogWarningcall