Removed RunAsyncVoid method #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a comment here on why we're removing it? |
I can... it's embarrassing but I had initially thought there were scenarios in which you couldn't catch an exception from an async void method which this extension could handle. It turns out there are no practical scenarios where that's true. The code in UI event handlers can just be wrapped in a try..catch and then there's no need for this extension method. It probably doesn't need any more detail than that since it would be the detail of an imaginary problem (not a real one) to which this extension method would be a solution. |
bitsandfoxes
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further testing, we can't find any use case for this extension method so we're removing it from the SDK.
Technically this is a breaking change. Alternatively, we could mark it obsolete instead and remove it in the next major release but it's highly improbably that anyone is using this method.