-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default Retry-After value #1537
Merged
mattjohnsonpint
merged 6 commits into
getsentry:main
from
mattjohnsonpint:add-default-retry-after
Mar 22, 2022
Merged
Add default Retry-After value #1537
mattjohnsonpint
merged 6 commits into
getsentry:main
from
mattjohnsonpint:add-default-retry-after
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to align with the SDK guidance at https://develop.sentry.dev/sdk/rate-limiting/#rate-limit-enforcement.
Codecov Report
@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
+ Coverage 84.30% 84.33% +0.03%
==========================================
Files 219 219
Lines 7417 7419 +2
Branches 1418 1418
==========================================
+ Hits 6253 6257 +4
Misses 736 736
+ Partials 428 426 -2
Continue to review full report at Codecov.
|
SimonCropp
reviewed
Mar 20, 2022
SimonCropp
reviewed
Mar 20, 2022
SimonCropp
reviewed
Mar 20, 2022
SimonCropp
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #1443
Refactored the logic for better readability as well.