Suppress P/Invoke warning for GetWindowThreadProcessId in UWP (#3372)

getsentry · May 16, 2024 · 7885354 · 7885354
1 parent a4a3c30
commit 7885354
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Fixes
+
+- P/Invoke warning for GetWindowThreadProcessId no longer shows when using Sentry in UWP applications ([#3372](https://github.com/getsentry/sentry-dotnet/pull/3372))
+
 ## 4.6.2
 
 ### Fixes

diff --git a/src/Sentry/Internal/ProcessInfo.cs b/src/Sentry/Internal/ProcessInfo.cs
@@ -149,6 +149,9 @@ private static DateTimeOffset GetStartupTime()
     [DllImport("user32.dll", CharSet = CharSet.Auto, ExactSpelling = true)]
     private static extern IntPtr GetForegroundWindow();
 
-    [DllImport("user32.dll", CharSet = CharSet.Auto, SetLastError = true)]
+    // GetWindowThreadProcessId is only available in the Windows SDK, so trying to call this from UWP apps will fail.
+    // We wrap use of this in a try/catch as a workaround. However, we need `ExactSpelling = true` here  to suppress
+    // warnings about the use of this API when compiling UWP applications.
+    [DllImport("user32.dll", CharSet = CharSet.Auto, SetLastError = true, ExactSpelling = true)]
     private static extern int GetWindowThreadProcessId(IntPtr handle, out int processId);
 }