feat(Android): Add docs for Sentry Kotlin Compiler Plugin #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
romtsn
reviewed
May 26, 2023
romtsn
reviewed
May 26, 2023
There was a problem hiding this comment.
This looks good, but what do you think about:
- Having a separate top-level section for the Kotlin Compiler Plugin, explaining its features and how it works (similar to Gradle).
- Then we could just link to that page from these two
- I think we should also update https://docs.sentry.io/platforms/android/configuration/integrations/jetpack-compose/ this page with the compiler plugin stuff. Perhaps, we could also mention the view hierarchy there?
- Dunno but maybe it's time to split this page up into subpages as well
src/platform-includes/enriching-events/attach-viewhierarchy/android.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/enriching-events/attach-viewhierarchy/android.mdx
Outdated
Show resolved
Hide resolved
src/platforms/android/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/android/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/android/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
I strongly agree with this suggestion. I don't think the current edits give users enough info about the plugin.
No super strong feelings about splitting up this page, but I'm fine with it. |
7 tasks
…entry/sentry-docs into feat/android-kotlin-compiler-plugin
romtsn
reviewed
Jun 2, 2023
src/platform-includes/enriching-events/attach-viewhierarchy/android.mdx
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Jun 2, 2023
…droid.mdx Co-authored-by: Roman Zavarnitsyn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources