Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): hide "Enable Tracing" section in... #5772

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

supervacuus
Copy link
Collaborator

... Performance Monitoring setup. sentry-native has no separate "Enabling" setup step (beyond configuring the trace sampling). This currently renders a misleading message raised here: getsentry/sentry-native#601 (comment).

@Swatinem pls have a look.

... Performance Monitoring setup.
@vercel
Copy link

vercel bot commented Nov 13, 2022

@supervacuus is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is also the performance/enable-tracing snippet that can now be removed?

@supervacuus
Copy link
Collaborator Author

supervacuus commented Nov 15, 2022

I believe there is also the performance/enable-tracing snippet that can now be removed?

maybe I misunderstand, but I think the missing-docs message appears exactly because that snippet is missing for native. If we had something to put into the "Enable Tracing" section, this would require a file native.mdx under src/platform-includes/performance/enable-tracing/. But there currently is none: https://github.com/getsentry/sentry-docs/tree/master/src/platform-includes/performance/enable-tracing

@Swatinem Swatinem merged commit 4ac7330 into getsentry:master Nov 16, 2022
@Swatinem
Copy link
Member

:-D okay, then I completely misunderstood that

@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants