-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Svelte SDK docs #5413
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,7 @@ | |||
title: Svelte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Don't know where else to put this.) Do we already have plans to upload a logo for svelte in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't done it yet but we either do it when we first publish the docs or when we go into beta. Still need to take a look at how we did it with Remix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly ready to go, but I've made some styling edits and a few other suggestions. I'd like to give this another review before you merge. Please tag me when it's ready for me to look at again.
@@ -0,0 +1,12 @@ | |||
Add a button to a Svelte component that throws an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section already has a lead-in sentence for the code snippet in the common content (see screenshot below):
So the lead-in text you've added doesn't make sense in this context. I can't make the suggestion directly here because the back ticks from the code snippet interfere, but I'd suggest that you remove the sentence about the button before the code snippet and add the following after the code snippet:
This snippet adds a button that throws an error to a Svelte component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think we have the same problem in the Remix SDK docs (which I took as an example). Will open another PR to adjust this (among some other things I came across)
Thanks for the great review @imatwawana
Updated the PR with all your suggestions. I think this is ready for another round! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one small comment, but otherwise, this looks great!
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
2ac24b3
to
a055b13
Compare
This PR adds official documentation to the new
@sentry/svelte
JS SDK which is currently in aplha. It includesref: getsentry/sentry-javascript#5573