-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trace-propagation-targets to unified API options #5382
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Just wondering if we should add a small example (similar to the one in the dev spec maybe?) to show what to specify here? The example could show a mix of regex and string and just a few URLs that would (not) match
@Lms24 How would you go about putting an example here? I thought about it a bit but we can't really rely on JS syntax on this page because it is more or less generic to all SDKs so we'd have to put different examples for all the different SDKs here. Do we want to do that? |
Good point. So, I took another look at the file and it seems like there are some options (e.g. in the deprecated section) with code examples. However, I'm realizing that this isn't simple for our case because ultimately this option should make it to all SDKs. I think we can do two things:
I'd vote for 2 as it seems the more straight forward way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing my feedback!
Adds documentation for the discussed
tracePropagationTargets
option. More context: DACI (internal)Related to changes in the JavaScript SDK: getsentry/sentry-javascript#5521