Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(serverless): new options for ignoring sentry errors #4755

Merged
merged 8 commits into from
Feb 24, 2022
Merged

ref(serverless): new options for ignoring sentry errors #4755

merged 8 commits into from
Feb 24, 2022

Conversation

ichina
Copy link
Contributor

@ichina ichina commented Feb 23, 2022 •
edited by AbhiPrasad
Loading

this pr was built on top of getsentry/sentry-javascript#4620

@vercel
Copy link

vercel bot commented Feb 23, 2022

@ichina is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@ichina ichina marked this pull request as ready for review February 23, 2022 13:49
AbhiPrasad
AbhiPrasad reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate all the help with this!

src/platforms/node/guides/aws-lambda/index.mdx Outdated Show resolved Hide resolved
src/platforms/node/guides/aws-lambda/index.mdx Outdated Show resolved Hide resolved
AbhiPrasad
AbhiPrasad approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can only be merged once the SDK is released.

@ichina
Copy link
Contributor Author

ichina commented Feb 23, 2022

@AbhiPrasad can u shed some light on when approximately will be next release?

@AbhiPrasad
Copy link
Member

By the end of this week!

@vercel
Copy link

vercel bot commented Feb 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/J9DBc31zUW9enH4TbR1xvJM8mHX3
✅ Preview: https://sentry-docs-git-fork-ichina-patch-2.sentry.dev

imatwawana
imatwawana approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor wording and style edits

src/platforms/node/guides/aws-lambda/index.mdx Outdated Show resolved Hide resolved
src/platforms/node/guides/aws-lambda/index.mdx Outdated Show resolved Hide resolved
src/platforms/node/guides/aws-lambda/index.mdx Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 24, 2022 13:59
@AbhiPrasad AbhiPrasad merged commit 32346f8 into getsentry:master Feb 24, 2022
@ichina ichina deleted the patch-2 branch February 24, 2022 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@imatwawana imatwawana imatwawana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ichina @AbhiPrasad @imatwawana