-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry-graphql
docs.
#4385
Add sentry-graphql
docs.
#4385
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/3Z5Rv23d5nSpxiW1Btv4tCThK2sD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor wording changes. I'm wondering about the location of this. Should it be under Configuration like this:
https://docs.sentry.io/platforms/android/configuration/integrations/fragment/
or these:
https://docs.sentry.io/platforms/javascript/configuration/integrations/
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Regarding the location - if we decide to move things under "Configuration -> Integrations", then I guess we should move other pages there too? Like this one: https://docs.sentry.io/platforms/java/guides/spring-boot/logging-frameworks/ I have no opinions here and will trust your decision. |
I guess integrations that have the ability to init the SDK as well can be under "Guides". sentry-graphql should go under integrations IMO, logback and log4j2 too. what do you think? |
For logback and log4j2, do you mean that the content should show up as both a guide and as a configuration? That seems like a confusing navigation experience to me. As for the placement of this content, I just wanted to raise the question of where it should go based on what I was seeing for JavaScript, but I don't feel super strongly about it. If we use this as our guide, does that clarify things at all: |
@imatwawana it's because the content of https://docs.sentry.io/platforms/java/guides/logback/ and https://docs.sentry.io/platforms/java/guides/spring-boot/logging-frameworks/#logback are slightly different, the same for log4j2. |
Ah okay. Apologies, I misunderstood. That makes sense to me. So to confirm we're all on the same page: And agreed, we can deal with the logging frameworks page on a different PR. |
exactly. |
Ok, GrapQL moved under "Integrations". "Integrations" is hidden from logging frameworks guide, as it would display empty page. |
Related to getsentry/sentry-java#1802