Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(flags): move min version requirements from index to integration docs #12215

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Dec 26, 2024

As we add and release more integrations, the versioning will be different for each one, so we should not specify it in the list of integrations.

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 1:04am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 1:04am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 1:04am

@aliu39 aliu39 requested review from a team and cmanallen December 26, 2024 22:48
Copy link

codecov bot commented Dec 26, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.36MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

@@ -29,7 +29,8 @@ This integration only works inside a browser environment. It is only available f

</Alert>

The [OpenFeature](https://openfeature.dev/) integration tracks feature flag evaluations produced by the OpenFeature SDK. These evaluations are held in memory, and in the event an error occurs, sent to Sentry for review and analysis. **At the moment, we only support boolean flag evaluations.**
The [OpenFeature](https://openfeature.dev/) integration tracks feature flag evaluations produced by the OpenFeature SDK. These evaluations are held in memory, and in the event an error occurs, sent to Sentry for review and analysis. **At the moment, we only support boolean flag evaluations.** This integration is available in
Sentry SDK **versions 8.43.0 or higher.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plural 'versions'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought it flowed a little better, but I'm ok either way

@aliu39 aliu39 merged commit 2b22a2e into master Dec 27, 2024
11 checks passed
@aliu39 aliu39 deleted the aliu/flags-versioning branch December 27, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants