docs: Add setup step 3 to the toolbar #12181
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
docs/product/dev-toolbar/setup.mdx
Outdated
| @@ -36,6 +36,10 @@ You need to complete two steps to get the toolbar rendered on the page: | |||
| </html> | |||
| ``` | |||
|
|
|||
| 3. Edit Project Settings in Sentry so the Toolbar is allowed to connect from your dev, staging, and production domains. | |||
There was a problem hiding this comment.
is it possible to link to the settings page from here?
There was a problem hiding this comment.
I can get to https://sentry.sentry.io/settings/projects/ but without knowing the project name i can't get closer
There was a problem hiding this comment.
ahh its project settings, not org settings. gotcha. could make it org settings?
There was a problem hiding this comment.
it's a per-project config
There was a problem hiding this comment.
why not make it an org config? cause what if you have multiple projects on the same domain?
There was a problem hiding this comment.
orgs can have like, their main website, but also all the backend tools with very different domains. kinda a security thing
if different projects are on the same domain that's ok. the request is for a project+domain pair. So everything could have localhost added to each of their lists no problem.
There was a problem hiding this comment.
the security position is that:
we're doing a login using sentry.io, so cookies and things never leave our own control. but org data is leaving sentry.io so I wanted to validate that we're exfiltrating those api responses to a domain known to the customer. This way org data only gets sent to domains the customer controls... then the sdk can use the data to render the toolbar.
This is against phishing cases: if a random site got someone to log into sentry we wouldn't be revealing api responses to that site because of cors in the usual cases, and because of this domain check if they try to abuse the iframe proxy that the toolbar uses.
Bundle ReportChanges will increase total bundle size by 9 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
| @@ -36,6 +36,10 @@ You need to complete two steps to get the toolbar rendered on the page: | |||
| </html> | |||
| ``` | |||
|
|
|||
| 3. Edit [Project Settings](https://sentry.io/orgredirect/organizations/:orgslug/settings/projects/) in Sentry so the Toolbar is allowed to connect from your dev, staging, and production domains. | |||
There was a problem hiding this comment.
This just redirects me to a random org (I thought it used to ask you to select an org?)
There was a problem hiding this comment.
it should take you to the last org you used, something like that
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Here's a snippet of what the changed pages look like now: