-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(develop): Clarify adding constraints #12169
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wait for owners-migrations before merging
FYI: https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-NOTES
|
@vbro thanks, this is covered in the section already:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for updating the docs 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this - I'm wondering if we should considering just banning the positive integer fields as well. Either that, or modify them to validate the constraint afterwards without the statement timeout
@wedamija We use them a lot on billing side for currency fields, so I'd lean towards the latter solution |
DESCRIBE YOUR PR
Updates develop docs Database Migrations page to clarify the caveats for adding any type of constraint (as opposed to just not null).
Adding Columns
Adding Not Null to Columns -> Adding Constraints to Columns (Including Not Null)
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: