Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api) Add ability for endpoint specific domains #12168

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

markstory
Copy link
Member

@markstory markstory commented Dec 17, 2024

DESCRIBE YOUR PR

Some of our endpoints require customers to use region domains in order to have APIs work correctly across DE and US regions. I've already updated those endpoints in getsentry/sentry#82159.

Refs getsentry/sentry#81232

Screenshot

Screenshot 2024-12-17 at 2 14 30 PM

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Some of our endpoints require customers to use region domains in order
to have APIs work correctly across DE and US regions. I've already
updated those endpoints in getsentry/sentry#82159.

Refs getsentry/sentry#81232
@markstory markstory requested a review from a team as a code owner December 17, 2024 19:25
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:42pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 7:42pm

Copy link

codecov bot commented Dec 17, 2024

Bundle Report

Changes will increase total bundle size by 60 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.35MB 66 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️
View changes by path for bundle: sentry-docs-server-cjs
File path Size Change
/[[...path]] 511.98kB 6 bytes (-0.0%)

@markstory markstory merged commit 984b323 into master Dec 17, 2024
13 checks passed
@markstory markstory deleted the region-url branch December 17, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants