feat(flags): document custom featureFlagsIntegration and refactor all JS integration docs #12151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
michellewzhang
approved these changes
Dec 16, 2024
Bundle ReportChanges will increase total bundle size by 10.34kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
|
python (not live atm): #12152 |
billyvg
reviewed
Dec 16, 2024
docs/platforms/javascript/common/configuration/integrations/featureFlags.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/configuration/integrations/featureFlags.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/configuration/integrations/featureFlags.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Billy Vong <[email protected]>
|
@billyvg Since your last 2 comments apply to all FF JS docs, I'll merge this and open new PRs to address them |
|
(With the @sentry/browser import) |
billyvg
reviewed
Dec 17, 2024
docs/platforms/javascript/common/configuration/integrations/featureFlags.mdx
Outdated
Show resolved
Hide resolved
|
Ok I won't rush merging. Have an idea for the import statement we can discuss tmrw |
billyvg
previously approved these changes
Dec 17, 2024
… docs (#12172) * ref(flags): add platform-specific content to JS integration docs * featureflags platforms * ld and of platforms * Rm 'Install with npm or yarn' * Label featureflags code as TypeScript * Update info alert and ffs link * Lowercase all code snippet language headers * Rewording from review * Use single quotes in all code snippets * Update provider pkg and docs links
aliu39
changed the title
cmanallen
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is live as of release 8.43. This doc follows the structure of integrations/launchdarkly.mdx and openfeature.mdx