Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline nuxt component tracking #11993

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 29, 2024

DESCRIBE YOUR PR

Ref getsentry/sentry-javascript#14265

Should only be merged once getsentry/sentry-javascript#14526 is released.

Aligns the nuxt component tracking docs with vue.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:22am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:22am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:22am

Copy link

codecov bot commented Nov 29, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.11MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this should not yet be merged

@lforst lforst merged commit fe8cabc into master Dec 2, 2024
11 checks passed
@lforst lforst deleted the lforst-nuxt-component-tracking branch December 2, 2024 14:47
aliu39 pushed a commit that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants