Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN: Updates capture feedback documentation #11980

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Nov 27, 2024

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

This PR updates the the captureFeedback documentation and removes the deprecated captureUserFeedback.

Partially getsentry/sentry-react-native#4319

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 1:31pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 1:31pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 1:31pm

@antonis antonis marked this pull request as draft November 27, 2024 16:34
Copy link

codecov bot commented Nov 27, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.35MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

@krystofwoldrich
Copy link
Member

@antonis I think this make sense to mark as ready for review and marge it with the release of https://github.com/getsentry/sentry-react-native/releases/tag/6.5.0-beta.1

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Dec 17, 2024

@antonis The UI Form changes can be a standalone docs change.

@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 17, 2024 12:44
krystofwoldrich added a commit to getsentry/sentry-react-native that referenced this pull request Dec 17, 2024
@antonis
Copy link
Collaborator Author

antonis commented Dec 17, 2024

@antonis The UI Form changes can be a standalone docs change.

Makes sense @krystofwoldrich 👍

@krystofwoldrich
Copy link
Member

When getsentry/sentry-react-native#4386 is release and out of beta we can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants