Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve dark theme detection on codeKeywords (Dsn selector) #11535

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Oct 9, 2024

fixes #11419

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 5:58pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 5:58pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 5:58pm

Copy link

codecov bot commented Oct 9, 2024

Bundle Report

Changes will increase total bundle size by 1 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 2 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 2 bytes (0.0%) ⬆️

@a-hariti
Copy link
Collaborator Author

a-hariti commented Oct 9, 2024

@chargome

TLDR; the issue seems to be fixed

the preview doesn't show the issue/solution as it only shows one project (example project)

if you want to verify, I suggest checkout the branch locally and edit the src/components/codeContext.tsx file and add another project (I copy pasted the existing one and changed the PROJECT_ID and the title

export const DEFAULTS: CodeKeywords = {
  PROJECT: [
    // ...
  ]
}

@a-hariti a-hariti merged commit 1b061d5 into master Oct 9, 2024
13 checks passed
@a-hariti a-hariti deleted the dsn-dark-mode branch October 9, 2024 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSN Selection is unreadable when using dark mode
2 participants