Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(apple): TTID/TTFD only for UIViewControllers #11530

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

philipphofmann
Copy link
Member

DESCRIBE YOUR PR

Add note that TTID/TTFD only work with UIViewControllers and not SwiftUI.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Add note that TTID/TTFD only work with UIViewControllers and not
SwiftUI.
@philipphofmann philipphofmann requested a review from a team October 9, 2024 14:33
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 2:50pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 2:50pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Oct 9, 2024 2:50pm

Copy link

codecov bot commented Oct 9, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to also add it to UIViewController Tracing

It says specifically it is for UIViewControllers but not sure if users get it confused with SwiftUI views

@philipphofmann
Copy link
Member Author

It says specifically it is for UIViewControllers but not sure if users get it confused with SwiftUI views

@buenaflor, I don't get that. Where exactly do you want me to put it? I merged the PR for now and will follow up with another one if required.

@philipphofmann philipphofmann merged commit fdd67ba into master Oct 10, 2024
11 checks passed
@philipphofmann philipphofmann deleted the impr/apple-ttid-ttfd branch October 10, 2024 07:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants