Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RN Gradle Integration Advance options #11163

Merged

Conversation

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:40pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:40pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Aug 29, 2024 10:40pm

Copy link

codecov bot commented Aug 28, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.26MB 6 bytes ⬇️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.26MB 6 bytes ⬇️

Comment on lines -183 to -211

### Enable Logging for `sentry-cli`

You can also enable logging for `sentry-cli` by adding this config before the above `apply from:` line:

```groovy {filename:android/app/build.gradle}
project.ext.sentryCli = [
logLevel: "debug"
]

apply from: "../../node_modules/@sentry/react-native/sentry.gradle"
```

### Fetch `sentry.properties`

We also support fetching different `sentry.properties` files for different flavors. For that, you need to add:

```groovy {filename:android/app/build.gradle}
project.ext.sentryCli = [
logLevel: "debug",
flavorAware: true
]

apply from: "../../node_modules/@sentry/react-native/sentry.gradle"
```

The corresponding flavor files should also be placed within the specific build type folder where you intend to use them. For example, the "Android demo release" flavor would be `react-native/android/sentry-demo-release.properties`.

We recommend leaving `logLevel: "debug"` since we look for specific `sentry.properties` files depending on your flavor's name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you remove this on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding!

@krystofwoldrich krystofwoldrich merged commit 5c2f27b into master Sep 3, 2024
10 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-rn-gradle-integration-advance-options branch September 3, 2024 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants