Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): use absolute url favicon #11113

Merged
merged 3 commits into from
Aug 16, 2024
Merged

fix(changelog): use absolute url favicon #11113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a485660
try absolute favicon for prod
chargome Aug 16, 2024
4ba3e5e
chore: update img-src csp for absolute favicon url
chargome Aug 16, 2024
9b6334d
chore: add comment
chargome Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed apps/changelog/src/app/favicon.ico
View file
Open in desktop
Binary file not shown.
6 changes: 5 additions & 1 deletion apps/changelog/src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ export const metadata: Metadata = {
title: 'Home',
icons: {
icon:
process.env.NODE_ENV === 'production' ? '/favicon.ico' : '/favicon_localhost.png',
// we use the absolute url (for the alternative prod domain),
// otherwise we run into the issue that sentry.io/changelog will not find the favicon
process.env.NODE_ENV === 'production'
? 'https://changelog.sentry.dev/favicon.ico'
chargome marked this conversation as resolved.
Show resolved Hide resolved
: '/favicon_localhost.png',
},
openGraph: {
images: '/img/hero.png',
Expand Down
4 changes: 2 additions & 2 deletions apps/changelog/vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
},
{
"key": "Content-Security-Policy-Report-Only",
"value": "default-src 'none'; font-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' plausible.io 'unsafe-inline' 'unsafe-eval' 'report-sample'; img-src 'self' storage.googleapis.com; worker-src blob:; connect-src o1.ingest.us.sentry.io plausible.io 'self' sentry.sentry.io; report-uri https://o1.ingest.us.sentry.io/api/4507670276341760/security/?sentry_key=e90f5ea060a4102c0a4c50c740e43ae1;"
"value": "default-src 'none'; font-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' plausible.io 'unsafe-inline' 'unsafe-eval' 'report-sample'; img-src 'self' storage.googleapis.com; worker-src blob:; connect-src o1.ingest.us.sentry.io plausible.io 'self' changelog.sentry.dev sentry.sentry.io; report-uri https://o1.ingest.us.sentry.io/api/4507670276341760/security/?sentry_key=e90f5ea060a4102c0a4c50c740e43ae1;"
}
]
}
],
"trailingSlash": true
}
}
Loading