-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: deduplicate and cleanup actions #2534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
changed the title
deduplicate and cleanup flutter actions
ci: deduplicate and cleanup flutter actions
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 265 265
Lines 9413 9413
=======================================
Hits 8197 8197
Misses 1216 1216 ☔ View full report in Codecov by Sentry. |
vaind
changed the title
ci: deduplicate and cleanup flutter actions
ci: deduplicate and cleanup actions
Dec 23, 2024
buenaflor
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thx 👍
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
69670c9 | 1269.18 ms | 1288.69 ms | 19.51 ms |
98d9a4a | 1244.73 ms | 1266.33 ms | 21.59 ms |
6ec7b50 | 1239.61 ms | 1268.93 ms | 29.32 ms |
2a0edba | 1229.27 ms | 1259.54 ms | 30.27 ms |
07cd9e8 | 1237.04 ms | 1257.50 ms | 20.46 ms |
5baa201 | 1250.63 ms | 1270.04 ms | 19.41 ms |
2d4fd8b | 1207.98 ms | 1232.94 ms | 24.96 ms |
2e93bab | 1237.08 ms | 1258.41 ms | 21.33 ms |
0a23f98 | 1252.98 ms | 1276.76 ms | 23.78 ms |
1cdcacf | 1208.35 ms | 1235.13 ms | 26.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
69670c9 | 8.10 MiB | 9.08 MiB | 1004.49 KiB |
98d9a4a | 8.33 MiB | 9.62 MiB | 1.29 MiB |
6ec7b50 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
2a0edba | 8.32 MiB | 9.52 MiB | 1.20 MiB |
07cd9e8 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
5baa201 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
2d4fd8b | 8.28 MiB | 9.34 MiB | 1.06 MiB |
2e93bab | 8.38 MiB | 9.73 MiB | 1.36 MiB |
0a23f98 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
1cdcacf | 8.32 MiB | 9.39 MiB | 1.06 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cd16818 | 316.57 ms | 375.19 ms | 58.62 ms |
5cc82a0 | 400.35 ms | 474.52 ms | 74.17 ms |
4829ad3 | 381.55 ms | 455.45 ms | 73.90 ms |
dd76eef | 461.37 ms | 540.55 ms | 79.18 ms |
752e1cb | 472.85 ms | 511.60 ms | 38.76 ms |
6078ddc | 385.72 ms | 463.61 ms | 77.89 ms |
9811573 | 309.76 ms | 402.60 ms | 92.84 ms |
ffae3e3 | 360.67 ms | 466.24 ms | 105.57 ms |
0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
c9d3212 | 301.34 ms | 361.58 ms | 60.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cd16818 | 6.26 MiB | 7.20 MiB | 956.08 KiB |
5cc82a0 | 6.34 MiB | 7.28 MiB | 966.66 KiB |
4829ad3 | 6.33 MiB | 7.26 MiB | 943.11 KiB |
dd76eef | 6.35 MiB | 7.40 MiB | 1.05 MiB |
752e1cb | 6.49 MiB | 7.57 MiB | 1.08 MiB |
6078ddc | 6.34 MiB | 7.29 MiB | 967.80 KiB |
9811573 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
ffae3e3 | 6.26 MiB | 7.20 MiB | 958.78 KiB |
0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
c9d3212 | 6.16 MiB | 7.14 MiB | 1010.90 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu-latest will soon change to ubuntu-24.04 so I was checking out what needs to be changes and noticed we have some duplicate code on flutter packages. This merges the code, similar to what we do for dart packages.
changes:
flutter upgrade
- there's really no reason to do this in CI after we've just installed latest versionwasm
&&js
builds to separate matrix itemsflutter test
for the current platform)