-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drift apm #1709
Merged
Merged
feat: drift apm #1709
Changes from 47 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
eff8bd0
draft impl
buenaflor 210f306
improve code
buenaflor 3caa4cd
Add open span
buenaflor a035435
Refactor to extend lazy database
buenaflor ea9e2d6
Update
buenaflor 64652a4
SentryTransactionExecutor
buenaflor dcabe06
Implement tracing batch and transactions
buenaflor a3a5fb9
Update tests
buenaflor d3a65b4
update changelog
buenaflor 9e54500
Formatting
buenaflor 92c56f4
Merge branch 'main' into feat/drift-apm
buenaflor 51f8041
Update workflows
buenaflor f089dde
Update deps
buenaflor 4c41212
Fix analyze issues
buenaflor 8d24a36
Format
buenaflor eeea299
Add example
buenaflor 2a108fe
Update descriptions
buenaflor 3ae85fe
Fix deps
buenaflor f077e06
Update run commands
buenaflor 084503a
Update workflow
buenaflor 36bc1fa
Update example
buenaflor a598fdb
Update workflow
buenaflor 9f93206
Format
buenaflor f92816a
Fix dart analyze
buenaflor b6b8650
Try changing deps
buenaflor 3e7f989
Add to craft
buenaflor 8443c42
Change to flutter test
buenaflor a2fa7bc
Revert flutter test mock
buenaflor c4da2d3
change dir manually
buenaflor 46dfa08
download and extract sqlite.dll for windows
buenaflor 63439aa
Try downloading sqlite3
buenaflor 5e513f9
set up dart
buenaflor 87ad6dd
fix path to file
buenaflor e7308e0
use pub get
buenaflor 38cae39
Use flutter pub get
buenaflor cbc8b43
fix
buenaflor 4ffeb6c
skip windows test
buenaflor a1e638e
fix analyze
buenaflor ebd8dd5
fix drift.yml
buenaflor ae7dd70
format
buenaflor ddc6bad
Remove redundant test
buenaflor 3df9151
Remove debug print
buenaflor d0a18eb
update trace origin
buenaflor df27999
Improvements
buenaflor d83844f
Improvements
buenaflor 8d68a84
Add to flutter example
buenaflor 40082e0
Skip web in examples
buenaflor 76065c7
Update comment
buenaflor 908d619
Fix web build
buenaflor bf5c20e
Try and set sqlite on windows
buenaflor 8b02069
trigger
buenaflor 9577c11
maybe fix workflow
buenaflor 984f88a
fix
buenaflor 9132516
trigger
buenaflor 0a58ba9
trigger
buenaflor 8b3928f
maybe trigger
buenaflor 42e88d3
maybe trigger
buenaflor 8b54152
maybe trigger
buenaflor 4f0af71
fix
buenaflor 78e56fc
try trigger
buenaflor 13e67e7
Merge branch 'main' into feat/drift-apm
buenaflor 6fb54e5
Merge branch 'main' into feat/drift-apm
buenaflor 9b0244b
update workflow
buenaflor 70910b3
try github_env
buenaflor 55a5f4e
try
buenaflor 0ffb3fa
try
buenaflor ee97635
try
buenaflor 467d970
try
buenaflor 26da22f
add to path
buenaflor bb3840a
skip windows
buenaflor 4b98cc8
formatting
buenaflor d9e12a6
try with embedded dll
buenaflor 921bf08
improvements
buenaflor 52cec3b
Formatting
buenaflor 8bb5fae
gitignore
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ on: | |
- "dio/**" | ||
- "file/**" | ||
- "sqflite/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ on: | |
- "flutter/**" | ||
- "file/**" | ||
- "sqflite/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
name: sentry-drift | ||
on: | ||
push: | ||
branches: | ||
- main | ||
- release/** | ||
pull_request: | ||
paths-ignore: | ||
- "**/*.md" | ||
- "logging/**" | ||
- "flutter/**" | ||
- "dio/**" | ||
- "file/**" | ||
- "sqflite/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Cancel Previous Runs | ||
uses: styfle/cancel-workflow-action@01ce38bf961b4e243a6342cbade0dbc8ba3f0432 # [email protected] | ||
with: | ||
access_token: ${{ github.token }} | ||
|
||
build: | ||
name: ${{ matrix.target }} | ${{ matrix.os }} | ${{ matrix.sdk }} | ||
runs-on: ${{ matrix.os }} | ||
timeout-minutes: 30 | ||
defaults: | ||
run: | ||
shell: bash | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
# skipping Windows for now since it requires sqlite3.dll to get working | ||
os: [ubuntu-latest, macos-latest] | ||
target: ["ios", "android", "macos", "linux"] | ||
sdk: ["stable", "beta"] | ||
exclude: | ||
- os: ubuntu-latest | ||
target: ios | ||
- os: ubuntu-latest | ||
target: macos | ||
- os: ubuntu-latest | ||
target: windows | ||
- os: windows-latest | ||
target: ios | ||
- os: windows-latest | ||
target: android | ||
- os: windows-latest | ||
target: macos | ||
- os: windows-latest | ||
target: linux | ||
# macos-latest is taking hours due to limited resources | ||
- os: macos-latest | ||
target: android | ||
- os: macos-latest | ||
target: linux | ||
- os: macos-latest | ||
target: windows | ||
# Bad CPU type in executable | ||
- os: macos-latest | ||
sdk: beta | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: actions/setup-java@v3 | ||
if: ${{ matrix.target == 'android' }} | ||
with: | ||
java-version: "11" | ||
distribution: "adopt" | ||
|
||
# Install required dependencies for Flutter on Linux on Ubuntu | ||
- name: "Setup Linux" | ||
run: | | ||
sudo apt update | ||
sudo apt install -y cmake dbus libblkid-dev libgtk-3-dev liblzma-dev ninja-build pkg-config xvfb | ||
sudo apt install -y network-manager upower | ||
if: matrix.os == 'ubuntu-latest' && matrix.target == 'linux' | ||
|
||
- uses: subosito/flutter-action@48cafc24713cca54bbe03cdc3a423187d413aafa # [email protected] | ||
with: | ||
channel: ${{ matrix.sdk }} | ||
|
||
- run: flutter upgrade | ||
|
||
- name: Pub Get | ||
run: | | ||
cd drift | ||
flutter pub get | ||
|
||
- name: Test VM with coverage | ||
run: | | ||
cd drift | ||
flutter test --coverage --test-randomize-ordering-seed=random | ||
|
||
- uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # pin@v3 | ||
if: runner.os == 'Linux' && matrix.sdk == 'stable' && matrix.target == 'linux' | ||
with: | ||
name: sentry_drift | ||
file: ./drift/coverage/lcov.info | ||
functionalities: "search" # remove after https://github.com/codecov/codecov-action/issues/600 | ||
|
||
- uses: VeryGoodOpenSource/very_good_coverage@e5c91bc7ce9843e87c800b3bcafdfb86fbe28491 # [email protected] | ||
if: runner.os == 'Linux' && matrix.sdk == 'stable' && matrix.target == 'linux' | ||
with: | ||
path: "./drift/coverage/lcov.info" | ||
min_coverage: 80 | ||
|
||
analyze: | ||
uses: ./.github/workflows/analyze.yml | ||
with: | ||
package: drift | ||
sdk: flutter |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ on: | |
- "flutter/**" | ||
- "dio/**" | ||
- "sqflite/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ on: | |
- "dio/**" | ||
- "file/**" | ||
- "sqflite/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ on: | |
- "flutter/**" | ||
- "file/**" | ||
- "sqflite/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ on: | |
- "**/*.md" | ||
- "file/**" | ||
- "sqflite/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ on: | |
- "flutter/**" | ||
- "dio/**" | ||
- "file/**" | ||
- "drift/**" | ||
|
||
jobs: | ||
cancel-previous-workflow: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Omit committing pubspec.lock for library packages; see | ||
# https://dart.dev/guides/libraries/private-files#pubspeclock. | ||
pubspec.lock | ||
|
||
# Flutter/Dart/Pub related | ||
**/doc/api/ | ||
**/ios/Flutter/.last_build_id | ||
.dart_tool/ | ||
.flutter-plugins | ||
.flutter-plugins-dependencies | ||
.packages | ||
.pub-cache/ | ||
.pub/ | ||
/build/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably also need this for the hive PR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we need to do an initial release first and afterwards add it to the registry so the integration can be retrieved in the docs etc.