-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Document PlatformDispatcher.onError
usage
#1082
Conversation
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
Previous results on branch: chore/updates-for-new-onerror-behaviour
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f0c0a87 | 335.51 ms | 385.94 ms | 50.43 ms |
02b2d6a | 301.08 ms | 346.15 ms | 45.06 ms |
fc1b104 | 292.76 ms | 348.82 ms | 56.06 ms |
61fb29d | 289.63 ms | 345.48 ms | 55.85 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f0c0a87 | 5.94 MiB | 6.92 MiB | 1005.78 KiB |
02b2d6a | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
fc1b104 | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
61fb29d | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56810ff | 1267.59 ms | 1293.48 ms | 25.89 ms |
322aa66 | 1251.68 ms | 1275.52 ms | 23.84 ms |
6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
eecbbca | 1264.90 ms | 1286.33 ms | 21.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56810ff | 8.15 MiB | 9.12 MiB | 987.35 KiB |
322aa66 | 8.15 MiB | 9.12 MiB | 992.53 KiB |
6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
eecbbca | 8.15 MiB | 9.10 MiB | 965.26 KiB |
Previous results on branch: chore/updates-for-new-onerror-behaviour
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd8fde8 | 1270.92 ms | 1307.80 ms | 36.88 ms |
f0c0a87 | 1285.11 ms | 1316.54 ms | 31.44 ms |
02b2d6a | 1262.92 ms | 1289.08 ms | 26.17 ms |
fc1b104 | 1264.53 ms | 1290.47 ms | 25.94 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd8fde8 | 8.15 MiB | 9.13 MiB | 1000.09 KiB |
f0c0a87 | 8.15 MiB | 9.13 MiB | 1000.06 KiB |
02b2d6a | 8.15 MiB | 9.13 MiB | 1000.11 KiB |
fc1b104 | 8.15 MiB | 9.13 MiB | 1000.14 KiB |
Codecov ReportBase: 90.09% // Head: 90.09% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 107 107
Lines 3393 3393
=======================================
Hits 3057 3057
Misses 336 336 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@marandaneto Removed the extra text from the tips section, as it only duplicates the one from above. |
Still missing #1082 (comment) |
#skip-changelog
📜 Description
Document
PlatformDispatcher.onError
usage📝 Checklist