Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace "http://sentry.io" with "https://sentry.io" #1073

Conversation

nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented Oct 11, 2022

📜 Description

We should use "https" instead of "http". Or was there any reason why http has been used?
#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor

Thanks @nilsreichardt

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 91.37% // Head: 91.37% // No change to project coverage 👍

Coverage data is based on head (be893c1) compared to base (56810ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files           9        9           
  Lines         197      197           
=======================================
  Hits          180      180           
  Misses         17       17           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto
Copy link
Contributor

marandaneto commented Oct 12, 2022

@vaind maybe we need a condition within the metrics job to not run when people don't have enough access (community PRs).

ERROR [2022-10-12 06:50:51.10]: Error cloning certificates git repo, please make sure you have access to the repository - see instructions above
INFO [2022-10-12 06:50:51.11]: Successfully generated documentation at path '/Users/runner/work/sentry-dart/sentry-dart/metrics/fastlane/README.md'

Similar to https://github.com/getsentry/sentry-android-gradle-plugin/blob/d59d745982b88649e2b89c5311a9f1a9c82dc15e/.github/workflows/test-publish.yaml#L36

@marandaneto marandaneto merged commit 72dfc83 into getsentry:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants