Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: collect SDK app metrics #1034

Merged
merged 18 commits into from
Oct 10, 2022
Merged

ci: collect SDK app metrics #1034

merged 18 commits into from
Oct 10, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Sep 30, 2022

See the overall issue at getsentry/team-mobile#5

#skip-changelog

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Base: 90.45% // Head: 91.37% // Increases project coverage by +0.91% 🎉

Coverage data is based on head (26af0cb) compared to base (0acb66c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
+ Coverage   90.45%   91.37%   +0.91%     
==========================================
  Files         114        9     -105     
  Lines        3584      197    -3387     
==========================================
- Hits         3242      180    -3062     
+ Misses        342       17     -325     
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_culture.dart
dart/lib/src/protocol/sentry_transaction.dart
dart/lib/src/sentry_envelope.dart
dart/lib/src/hub.dart
dart/lib/src/diagnostic_logger.dart
dart/lib/src/protocol/sentry_id.dart
dart/lib/src/protocol/sentry_user.dart
dart/lib/src/protocol/sentry_gpu.dart
...ib/src/environment/_web_environment_variables.dart
dart/lib/src/default_integrations.dart
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vaind vaind force-pushed the ci/collect-metrics branch from cc72910 to 89de595 Compare September 30, 2022 15:46
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 294.22 ms 346.58 ms 52.36 ms
Size 5.94 MiB 6.92 MiB 1001.18 KiB

Previous results on branch: ci/collect-metrics

Startup times

Revision Plain With Sentry Diff
1912cb0 332.56 ms 373.98 ms 41.42 ms
ea58de8 299.92 ms 375.33 ms 75.41 ms
3c7f174 363.98 ms 377.66 ms 13.68 ms

App size

Revision Plain With Sentry Diff
1912cb0 5.94 MiB 6.92 MiB 1003.80 KiB
ea58de8 5.94 MiB 6.92 MiB 1003.80 KiB
3c7f174 5.94 MiB 6.92 MiB 1001.18 KiB

@vaind vaind force-pushed the ci/collect-metrics branch 2 times, most recently from 677f118 to 1185870 Compare October 10, 2022 10:44
@vaind vaind force-pushed the ci/collect-metrics branch from 1185870 to e1f088f Compare October 10, 2022 13:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1298.61 ms 1325.86 ms 27.24 ms
Size 8.15 MiB 9.12 MiB 986.32 KiB

Previous results on branch: ci/collect-metrics

Startup times

Revision Plain With Sentry Diff
3c7f174 1248.16 ms 1261.41 ms 13.24 ms
ea58de8 1289.39 ms 1310.69 ms 21.31 ms
1912cb0 1287.61 ms 1300.16 ms 12.55 ms

App size

Revision Plain With Sentry Diff
3c7f174 8.15 MiB 9.12 MiB 986.25 KiB
ea58de8 8.15 MiB 9.12 MiB 986.23 KiB
1912cb0 8.15 MiB 9.12 MiB 986.26 KiB

@vaind vaind force-pushed the ci/collect-metrics branch from d27c5e4 to 7f0e5b1 Compare October 10, 2022 15:41
@vaind vaind marked this pull request as ready for review October 10, 2022 16:09
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vaind

@marandaneto marandaneto merged commit 3e5ee37 into main Oct 10, 2022
@marandaneto marandaneto deleted the ci/collect-metrics branch October 10, 2022 17:10
@denrase denrase mentioned this pull request Dec 10, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants