Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Replay quality option #4035

Merged
merged 3 commits into from
Jun 5, 2024
Merged

feat: Add Replay quality option #4035

merged 3 commits into from
Jun 5, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Added replay quality option.

We have 3 alternatives: low, medium, high.

  • Low: 80% size scale, 20000 bps
  • Medium: 100% size scale, 40000 bps
  • High: 100% size scale, 60000 bps

💚 How did you test it?

Unit test, sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Jun 4, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c15cfce

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.133%. Comparing base (96af87c) to head (c15cfce).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4035       +/-   ##
=============================================
+ Coverage   91.106%   91.133%   +0.026%     
=============================================
  Files          608       609        +1     
  Lines        47497     47629      +132     
  Branches     17044     17109       +65     
=============================================
+ Hits         43273     43406      +133     
+ Misses        4154      4042      -112     
- Partials        70       181      +111     
Files Coverage Δ
...tegrations/SessionReplay/SentryReplayOptions.swift 100.000% <100.000%> (+13.636%) ⬆️
...tions/SessionReplay/SentryReplayOptionsTests.swift 100.000% <100.000%> (ø)

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96af87c...c15cfce. Read the comment docs.

Copy link

github-actions bot commented Jun 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.71 ms 1255.16 ms 18.45 ms
Size 21.58 KiB 656.60 KiB 635.02 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
277f226 1241.65 ms 1253.74 ms 12.09 ms
2cf1b84 1221.10 ms 1230.34 ms 9.24 ms
db33900 1232.87 ms 1250.35 ms 17.47 ms
f25febb 1209.08 ms 1225.90 ms 16.81 ms
add8416 1270.72 ms 1300.38 ms 29.66 ms
861d361 1227.90 ms 1231.45 ms 3.55 ms
b35ccd0 1233.92 ms 1256.69 ms 22.78 ms
c9724f9 1199.38 ms 1229.54 ms 30.16 ms
7512778 1200.78 ms 1206.33 ms 5.55 ms
f2daa68 1238.40 ms 1256.43 ms 18.03 ms

App size

Revision Plain With Sentry Diff
277f226 22.84 KiB 401.67 KiB 378.83 KiB
2cf1b84 20.76 KiB 431.91 KiB 411.15 KiB
db33900 21.58 KiB 418.40 KiB 396.82 KiB
f25febb 21.58 KiB 414.92 KiB 393.34 KiB
add8416 21.58 KiB 541.91 KiB 520.33 KiB
861d361 20.76 KiB 435.65 KiB 414.89 KiB
b35ccd0 21.58 KiB 573.13 KiB 551.55 KiB
c9724f9 20.76 KiB 427.66 KiB 406.90 KiB
7512778 21.58 KiB 539.87 KiB 518.29 KiB
f2daa68 21.58 KiB 418.40 KiB 396.82 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 5e579af into main Jun 5, 2024
69 of 70 checks passed
@brustolin brustolin deleted the feat(SR)/video-quality branch June 5, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants