-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Read initWithDict for Hybrid SDKs #2579
Conversation
Add SentryOptions:initWithDict only for Hybrid SDKs again. Fixes GH-2547
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
58ec104 | 1244.29 ms | 1269.67 ms | 25.39 ms |
766d549 | 1214.00 ms | 1222.74 ms | 8.74 ms |
9f8d429 | 1239.57 ms | 1255.12 ms | 15.55 ms |
6c7ab81 | 1231.66 ms | 1251.58 ms | 19.92 ms |
53e149f | 1213.62 ms | 1253.40 ms | 39.77 ms |
c7d7a55 | 1198.46 ms | 1227.64 ms | 29.18 ms |
10f5348 | 1257.04 ms | 1266.52 ms | 9.48 ms |
1018de3 | 1251.20 ms | 1254.06 ms | 2.86 ms |
88ac2c2 | 1223.04 ms | 1243.12 ms | 20.08 ms |
b9c9598 | 1228.57 ms | 1251.10 ms | 22.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
58ec104 | 20.75 KiB | 379.11 KiB | 358.36 KiB |
766d549 | 20.76 KiB | 406.02 KiB | 385.26 KiB |
9f8d429 | 20.75 KiB | 383.40 KiB | 362.65 KiB |
6c7ab81 | 20.75 KiB | 405.10 KiB | 384.34 KiB |
53e149f | 20.75 KiB | 402.12 KiB | 381.36 KiB |
c7d7a55 | 20.75 KiB | 383.40 KiB | 362.65 KiB |
10f5348 | 20.75 KiB | 402.11 KiB | 381.36 KiB |
1018de3 | 20.75 KiB | 402.08 KiB | 381.33 KiB |
88ac2c2 | 20.75 KiB | 373.61 KiB | 352.86 KiB |
b9c9598 | 20.75 KiB | 383.77 KiB | 363.01 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2579 +/- ##
==========================================
+ Coverage 79.09% 79.39% +0.29%
==========================================
Files 243 243
Lines 22325 22446 +121
Branches 9871 9952 +81
==========================================
+ Hits 17659 17821 +162
+ Misses 4212 4172 -40
+ Partials 454 453 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't CI complain about that? What can we do to avoid that mistake in the future by CI complaining? |
Compiler is forgiven to headers not being used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something wrong in the CHANGELOG.
Other than that, LGTM
📜 Description
Add SentryOptions:initWithDict only for Hybrid SDKs again.
#skip-changelog
💡 Motivation and Context
Fixes GH-2547
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps