Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Fix outdated comment in SessionTracker #2381

Merged
merged 1 commit into from
Nov 14, 2022
Merged

ref: Fix outdated comment in SessionTracker #2381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Sources/Sentry/SentrySessionTracker.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,11 @@ - (void)endCachedSession
* regardless of whether your app uses scenes, see
* https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622956-applicationdidbecomeactive.
*
* We can't start the session in this method because we don't know if a background task or a hybrid
* SDK initialized the SDK. Hybrid SDKs must only post this notification if they are running in the
* foreground because the auto session tracking logic doesn't support background tasks. Posting the
* notification from the background would mess up the session stats.
* Hybrid SDKs must only post this notification if they are running in the foreground because the
* auto session tracking logic doesn't support background tasks. Posting the notification from the
* background would mess up the session stats. Hybrid SDKs must only post this notification if they
* are running in the foreground because the auto session tracking logic doesn't support background
* tasks. Posting the notification from the background would mess up the session stats.
*/
- (void)didBecomeActive
{
Expand Down