Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Fix Xcode 14 compile issues #2145

Merged
merged 2 commits into from
Sep 13, 2022
Merged

ref: Fix Xcode 14 compile issues #2145

merged 2 commits into from
Sep 13, 2022

Conversation

philipphofmann
Copy link
Member

#skip-changelog

brustolin
brustolin approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Sep 13, 2022 •
edited
Loading

Performance metrics 🚀

Plain With Sentry Diff
Startup time (ms) 1243.25 1266.48 23.23
Size (bytes) 21157 333611 312454

@kevinrenskers
Copy link
Contributor

I also fixed the tests, so now you have a merge conflict. I didn't have any compile errors related to getAbsoluteTime 🤔

@philipphofmann philipphofmann merged commit f273eda into master Sep 13, 2022
@philipphofmann philipphofmann deleted the ref/fix-xcode-14-build-issues branch September 13, 2022 10:11
@philipphofmann
Copy link
Member Author

I was using the RC version. Maybe that's why.

kevinrenskers added a commit that referenced this pull request Sep 13, 2022
@kevinrenskers
Merge branch 'master' into fix/fix-flaky-tests
46885db 
* master:
  Run tests on iOS 16 using Xcode 14.0 (#2147)
  ref: Fix Xcode 14 compile issues (#2145)
  Provide fallbacks for assertions in production (#2141)

# Conflicts:
#	scripts/xcode-test.sh
kevinrenskers added a commit that referenced this pull request Sep 15, 2022
@kevinrenskers
Merge branch 'master' into fix/1072-fix-double-quote-warnings
e05b919 
* master: (73 commits)
  ref: Fix typo in measurement (#2154)
  Fix typos in changelog (#2153)
  docs: Add a note on flaky tests to Contributing (#2161)
  docs: fix PR reference in CHANGELOG (#2157)
  test: generate graphs for benchmarks (#2158)
  release: 7.25.1
  fix: Prewarmed app start detection (#2151)
  ci: temporarily disable scheduled CI runs uploading profiles/symbols (#2152)
  Run tests on iOS 16 using Xcode 14.0 (#2147)
  ref: Fix Xcode 14 compile issues (#2145)
  Provide fallbacks for assertions in production (#2141)
  Fix compile errors in Xcode 14 (#2146)
  release: 7.25.0
  fix: setting SDK name through options[sdk][name] shouldn't clear version (#2139)
  fix: SentryTracer instances should be called "tracer", not "transaction" (#2137)
  ref: functions to convert to/from enum cases (#2108)
  fix: Crash with screenshot is reported twice (#2134)
  meta: Clarify PR rules in Contributing (#2133)
  meta: Fix Changelog (#2136)
  feat: Add support for dynamic library (#1726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

@armcknight armcknight Awaiting requested review from armcknight

@indragiek indragiek Awaiting requested review from indragiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipphofmann @kevinrenskers @brustolin