Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK version is not displayed in dashboard #2010

Closed
tustanivsky opened this issue Jul 27, 2022 · 11 comments · Fixed by #2139
Closed

SDK version is not displayed in dashboard #2010

tustanivsky opened this issue Jul 27, 2022 · 11 comments · Fixed by #2139

Comments

@tustanivsky
Copy link

Description

In sentry-unreal (Sentry plugin for Unreal Engine) we're using sentry-cocoa internally for crash capturing on iOS. After updating it to version 7.22.0 I've noticed that the SDK version is not displayed in dashboard anymore.

A similar issue was confirmed for sentry-unity as well.

unknown
.

@brustolin
Copy link
Contributor

Hello @tustanivsky, thanks for the input, we will investigate this.

@brustolin brustolin moved this from Needs Discussion to Needs Investigation in Mobile & Cross Platform SDK Aug 10, 2022
@brustolin
Copy link
Contributor

@bitsandfoxes Can you help us out here. We dont have this problem happening with cocoa projects. Maybe something related to the binding for Unity?

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Aug 16, 2022

Unity is on Cocoa v7.23.0 right now and does not have this issue. Events reported through the Cocoa SDK show up as sentry.cocoa.unity.

@bitsandfoxes bitsandfoxes removed their assignment Aug 16, 2022
@philipphofmann
Copy link
Member

@tustanivsky, can you check the comment above and let us know if you still experience the issue?

@tustanivsky
Copy link
Author

tustanivsky commented Aug 31, 2022

@tustanivsky, can you check the comment above and let us know if you still experience the issue?

@philipphofmann Yes, Unreal plugin is on Cocoa v7.23.0 as well and this issue still persists (check it out here). As you can see package name is sentry.cocoa.unreal which is correct, though the version is not displayed

@bitsandfoxes
Copy link
Contributor

I stand corrected: It's made its way into the Unity SDK as well: getsentry/sentry-unity#950

@philipphofmann
Copy link
Member

Ah, now I think I get it. If you pass down the SDK name sentry.cocoa.unreal or sentry.cocoa.unity the cocoa SDK doesn't send the version properly, @tustanivsky?

@tustanivsky
Copy link
Author

Ah, now I think I get it. If you pass down the SDK name sentry.cocoa.unreal or sentry.cocoa.unity the cocoa SDK doesn't send the version properly, @tustanivsky?

Yes, correct

@philipphofmann philipphofmann moved this from Needs Investigation to Needs Discussion in Mobile & Cross Platform SDK Sep 1, 2022
@vaind
Copy link
Collaborator

vaind commented Sep 5, 2022

This has been caused by #1960 - we need to adapt the Unity & Unreal SDKs to fix that.

The issue with the empty version string is caused by this line https://github.com/getsentry/sentry-cocoa/blob/master/Sources/Sentry/SentryOptions.m#L336

Previously if the given version was empty, it was be ignored.

https://github.com/getsentry/sentry-cocoa/blob/master/Sources/Sentry/SentrySdkInfo.m#L51

Now it just writes whatever is given (nullptr)

@vaind
Copy link
Collaborator

vaind commented Sep 5, 2022

I've updated the respective issues in Unreal & Unity with the info that we need to use PrivateSentrySDKOnly.

What is missing with the current code, however, is the option to set only a name or a version, not both. Can someone make the changes to PrivateSentrySDKOnly to expose that? Ideally also a getter for both name & version because it's also used by the Dart SDK to add info to the events coming from Dart - reading the now deprecated options.sdkVersion

@philipphofmann
Copy link
Member

Yep, we can change that easily. How important / urgent is that for you, @vaind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants