fix: Crash in profiling logger (#1964)

Call va_end after creating the NSString *, otherwise this is undefined behavior and can crash. Co-authored-by: Sentry Github Bot <[email protected]>
getsentry · Jul 12, 2022 · ce1b8d1 · ce1b8d1
1 parent 0be48b6
commit ce1b8d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 - Properly sanitize the event context and SDK information (#1943)
 - Don't send error 429 as `network_error` (#1957)
 - Deprecate not needed option `sdkInfo` (#1960)
+- Crash in profiling logger (#1964)
 
 ## 7.20.0
 

diff --git a/Sources/Sentry/SentryProfilingLogging.mm b/Sources/Sentry/SentryProfilingLogging.mm
@@ -33,10 +33,10 @@
         }
         va_list args;
         va_start(args, fmt);
-        va_end(args);
         const auto fmtStr = [[NSString alloc] initWithUTF8String:fmt];
-        [SentryLog logWithMessage:[[NSString alloc] initWithFormat:fmtStr arguments:args]
-                         andLevel:sentryLevelFromLogLevel(level)];
+        const auto msgStr = [[NSString alloc] initWithFormat:fmtStr arguments:args];
+        va_end(args);
+        [SentryLog logWithMessage:msgStr andLevel:sentryLevelFromLogLevel(level)];
     }
 
 } // namespace profiling