Skip to content

Commit

Permalink
Merge e59bff3 into d1d5c2d
Browse files Browse the repository at this point in the history
  • Loading branch information
philipphofmann authored Mar 3, 2023
2 parents d1d5c2d + e59bff3 commit 542210a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 2 deletions.
9 changes: 9 additions & 0 deletions Sources/Sentry/SentryClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ - (instancetype)initWithOptions:(SentryOptions *)options
SentryTransportAdapter *transportAdapter =
[[SentryTransportAdapter alloc] initWithTransport:transport options:options];

return [self initWithOptions:options fileManager:fileManager transportAdapter:transportAdapter];
}

/** Internal constructor for testing purposes. */
- (instancetype)initWithOptions:(SentryOptions *)options
fileManager:(SentryFileManager *)fileManager
transportAdapter:(SentryTransportAdapter *)transportAdapter

{
SentryInAppLogic *inAppLogic =
[[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes
inAppExcludes:options.inAppExcludes];
Expand Down
4 changes: 4 additions & 0 deletions Tests/SentryTests/SentryClient+TestInit.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ SentryClient ()
- (_Nullable instancetype)initWithOptions:(SentryOptions *)options
fileManager:(SentryFileManager *)fileManager;

- (instancetype)initWithOptions:(SentryOptions *)options
fileManager:(SentryFileManager *)fileManager
transportAdapter:(SentryTransportAdapter *)transportAdapter;

- (instancetype)initWithOptions:(SentryOptions *)options
transportAdapter:(SentryTransportAdapter *)transportAdapter
fileManager:(SentryFileManager *)fileManager
Expand Down
8 changes: 6 additions & 2 deletions Tests/SentryTests/TestClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@ import Foundation

class TestClient: SentryClient {
override init?(options: Options) {
super.init(options: options, fileManager: try! TestFileManager(options: options))
super.init(options: options, fileManager: try! TestFileManager(options: options), transportAdapter: TestTransportAdapter(transport: TestTransport(), options: options))
}

override init?(options: Options, fileManager: SentryFileManager) {
super.init(options: options, fileManager: fileManager)
super.init(options: options, fileManager: fileManager, transportAdapter: TestTransportAdapter(transport: TestTransport(), options: options))
}

override init(options: Options, fileManager: SentryFileManager, transportAdapter: SentryTransportAdapter) {
super.init(options: options, fileManager: fileManager, transportAdapter: transportAdapter)
}

// Without this override we get a fatal error: use of unimplemented initializer
Expand Down

0 comments on commit 542210a

Please sign in to comment.