feat: Remove timezone from device context

Continuation of #2036 #skip-changelog
getsentry · Aug 24, 2022 · 1d48c94 · 1d48c94
1 parent 02d15f7
commit 1d48c94
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 9 deletions.
diff --git a/Sources/Sentry/SentryCrashIntegration.m b/Sources/Sentry/SentryCrashIntegration.m
@@ -250,7 +250,6 @@ + (void)enrichScope:(SentryScope *)scope crashWrapper:(SentryCrashWrapper *)cras
     [deviceData setValue:systemInfo[@"memorySize"] forKey:@"memory_size"];
     [deviceData setValue:systemInfo[@"storageSize"] forKey:@"storage_size"];
     [deviceData setValue:systemInfo[@"bootTime"] forKey:@"boot_time"];
-    [deviceData setValue:systemInfo[@"timezone"] forKey:@"timezone"];
 
     NSString *locale = [[NSLocale autoupdatingCurrentLocale] objectForKey:NSLocaleIdentifier];
     [deviceData setValue:locale forKey:LOCALE_KEY];

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitorContext.h b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitorContext.h
@@ -196,7 +196,6 @@ typedef struct SentryCrash_MonitorContext {
         int cpuSubType;
         int binaryCPUType;
         int binaryCPUSubType;
-        const char *timezone;
         const char *processName;
         int processID;
         int parentProcessID;

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m
@@ -66,7 +66,6 @@
     int cpuSubType;
     int binaryCPUType;
     int binaryCPUSubType;
-    const char *timezone;
     const char *processName;
     int processID;
     int parentProcessID;
@@ -562,7 +561,6 @@
         g_systemData.cpuSubType = sentrycrashsysctl_int32ForName("hw.cpusubtype");
         g_systemData.binaryCPUType = header->cputype;
         g_systemData.binaryCPUSubType = header->cpusubtype;
-        g_systemData.timezone = cString([NSTimeZone localTimeZone].name);
         g_systemData.processName = cString([NSProcessInfo processInfo].processName);
         g_systemData.processID = [NSProcessInfo processInfo].processIdentifier;
         g_systemData.parentProcessID = getppid();
@@ -616,7 +614,6 @@
         COPY_REFERENCE(cpuSubType);
         COPY_REFERENCE(binaryCPUType);
         COPY_REFERENCE(binaryCPUSubType);
-        COPY_REFERENCE(timezone);
         COPY_REFERENCE(processName);
         COPY_REFERENCE(processID);
         COPY_REFERENCE(parentProcessID);

diff --git a/Sources/SentryCrash/Recording/SentryCrash.m b/Sources/SentryCrash/Recording/SentryCrash.m
@@ -253,7 +253,6 @@ - (NSDictionary *)systemInfo
     COPY_PRIMITIVE(cpuSubType);
     COPY_PRIMITIVE(binaryCPUType);
     COPY_PRIMITIVE(binaryCPUSubType);
-    COPY_STRING(timezone);
     COPY_STRING(processName);
     COPY_PRIMITIVE(processID);
     COPY_PRIMITIVE(parentProcessID);

diff --git a/Sources/SentryCrash/Recording/SentryCrashReport.c b/Sources/SentryCrash/Recording/SentryCrashReport.c
@@ -1622,8 +1622,6 @@ writeSystemInfo(const SentryCrashReportWriter *const writer, const char *const k
             writer, SentryCrashField_BinaryCPUType, monitorContext->System.binaryCPUType);
         writer->addIntegerElement(
             writer, SentryCrashField_BinaryCPUSubType, monitorContext->System.binaryCPUSubType);
-        writer->addStringElement(
-            writer, SentryCrashField_TimeZone, monitorContext->System.timezone);
         writer->addStringElement(
             writer, SentryCrashField_ProcessName, monitorContext->System.processName);
         writer->addIntegerElement(

diff --git a/Sources/SentryCrash/Recording/SentryCrashReportFields.h b/Sources/SentryCrash/Recording/SentryCrashReportFields.h
@@ -209,7 +209,6 @@
 #define SentryCrashField_Storage "storage"
 #define SentryCrashField_SystemName "system_name"
 #define SentryCrashField_SystemVersion "system_version"
-#define SentryCrashField_TimeZone "time_zone"
 #define SentryCrashField_BuildType "build_type"
 
 #endif