ref(dif): Genericize poll_assemble
#2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-8
branch
from
6a6c455 to
181fbf0
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-7
branch
from
f835979 to
53ee484
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-8
branch
from
181fbf0 to
99e7bae
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-8
branch
from
99e7bae to
2c576c0
Compare
loewenheim
approved these changes
Dec 6, 2024
This requires adding `should_wait` and `max_wait` functions to the `ChunkOptions` trait.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-8
branch
from
2c576c0 to
1d5d593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires adding
should_waitandmax_waitfunctions to theChunkOptionstrait.