ref(proguard): Replace MappingRef with ProguardMapping #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-3
branch
from
32a81fc to
a3220cd
Compare
szokeasaurusrex
changed the title
proguard utils submodule
The new `ProguardMapping` type directly references the `ByteView` of the Proguard file, rather than simply storing the path to the file. This change will enable us to replace `ChunkedMapping` with `Chunked<ProguardMapping>`. ref #2196
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-3
branch
from
a3220cd to
543e79e
Compare
loewenheim
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
ProguardMappingtype directly references theByteViewof the Proguard file, rather than simply storing the path to the file. This change will enable us to replaceChunkedMappingwithChunked<ProguardMapping>.