Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/WIP: e2e sibling test #795

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

feat/WIP: e2e sibling test #795

wants to merge 19 commits into from

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Nov 26, 2024

This PR introduces new tests to evaluate how package managers behave when installing or updating sibling SDKs alongside Sentry Capacitor.

Tests Included:

  1. Updating Existing Installations

    • Run yarn install/npm install when both Sentry Capacitor and a sibling SDK are already installed to update the libraries.
  2. Adding a Sibling SDK

    • Install a sibling SDK using yarn add ... or npm install ... when Sentry Capacitor is already installed.
  3. Fresh Installations

    • Install both Sentry Capacitor and a sibling SDK when neither is currently installed.

Validation:

For each test involving sibling SDKs:

  • Verify success when the correct sibling versions are installed.
  • Ensure failures occur for incompatible versions.

Coverage:

This PR will cover npm, Yarn Classic, and Yarn v3. By adding these tests, we significantly enhance the coverage for installation and update scenarios involving Sentry Capacitor, ensuring better reliability and user experience.

#skip-changelog


cp package.json package.json.bak

yalc add @sentry/capacitor
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We create this folder because it loads faster than pointing yarn to install the root project (10 minutes vs 5 seconds) on the sibling tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant