Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: contexts serializer avoids reflection and fixes desugaring issue #478

Merged
merged 2 commits into from
Jul 6, 2020
Merged

fix: contexts serializer avoids reflection and fixes desugaring issue #478

merged 2 commits into from
Jul 6, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 3, 2020

📢 Type of change

  • [X ] Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fix: contexts serializer avoids reflection and fixes desugaring issue

💡 Motivation and Context

#476

💚 How did you test it?

running it, tests are already in place

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Maybe we need this for Extra too?

@marandaneto
Copy link
Contributor Author

Good one. Maybe we need this for Extra too?

no, this only happens when it extends the thread-safe version of it.
because of https://developer.android.com/studio/write/java8-support?hl=fi#library-desugaring
they desugar ConcurrentHashMap specifically.

@marandaneto marandaneto merged commit ac660f2 into getsentry:master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants