Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

avoid crash if NDK throws UnsatisfiedLinkError #344

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 7, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

avoid crash if NDK throws UnsatisfiedLinkError.

💡 Motivation and Context

While this doesn't fix #341 it might help till we get there.

💚 How did you test it?

threw UnsatisfiedLinkError myself

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

consider https://github.com/KeepSafe/ReLinker as it's recommended in the Android official docs anyway.

@marandaneto marandaneto requested a review from bruno-garcia April 7, 2020 06:36
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@bruno-garcia bruno-garcia merged commit b07e0d5 into master Apr 7, 2020
@bruno-garcia bruno-garcia deleted the fix/avoid-crash-unsatisfiedlinkerror branch April 7, 2020 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsatisfiedLinkError in SentryNdk
2 participants