Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

renaming transport gate method #330

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 31, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

renaming transport gate method

💡 Motivation and Context

isSendingAllowed() seems to be related to our RetryAfter impl., but actually this checks wether if the device is online or not, so isConnected would be better.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@marandaneto marandaneto merged commit dbf6163 into master Mar 31, 2020
@marandaneto marandaneto deleted the enha/rename-transport-gate-method branch March 31, 2020 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants