This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
requested review from
metlos and
bruno-garcia
and removed request for
metlos
January 16, 2020 14:07
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
Coverage ? 58.13%
Complexity ? 574
=========================================
Files ? 72
Lines ? 2706
Branches ? 237
=========================================
Hits ? 1573
Misses ? 1014
Partials ? 119
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Jan 17, 2020
sentry-core/src/main/java/io/sentry/core/transport/RetryingThreadPoolExecutor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Honor Sentry RetryAfter.
💡 Motivation and Context
RetryAfter was implemented differently, per event, like the sentry-java SDK, but it's not honoring the unified API.
💚 How did you test it?
unit tests and manual tests.
📝 Checklist
🔮 Next steps