Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

more device context (deviceId, connectionType and language) #229

Merged
merged 6 commits into from
Jan 16, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

more device context.

💡 Motivation and Context

more device context, like deviceId, connectionType and language.

💚 How did you test it?

executing and a single unit test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #229   +/-   ##
========================================
  Coverage      58.8%   58.8%           
  Complexity      570     570           
========================================
  Files            72      72           
  Lines          2653    2653           
  Branches        235     235           
========================================
  Hits           1560    1560           
  Misses          979     979           
  Partials        114     114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf93ab...48036f5. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes but LGTM!

@marandaneto marandaneto merged commit 581fb79 into master Jan 16, 2020
@marandaneto marandaneto deleted the enha/more_device_context branch January 16, 2020 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants