Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

throw an exception if DSN is not set #200

Merged
merged 3 commits into from
Dec 13, 2019
Merged

throw an exception if DSN is not set #200

merged 3 commits into from
Dec 13, 2019

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

throw an exception if DSN is not set.

💡 Motivation and Context

if DSN is not set, user needs to know right away, it might be a misconfiguration.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #200 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
- Coverage     57.94%   57.94%   -0.01%     
- Complexity      547      548       +1     
============================================
  Files            72       72              
  Lines          2611     2613       +2     
  Branches        227      228       +1     
============================================
+ Hits           1513     1514       +1     
- Misses          981      983       +2     
+ Partials        117      116       -1
Impacted Files Coverage Δ Complexity Δ
...ntry-core/src/main/java/io/sentry/core/Sentry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/main/java/io/sentry/core/DirectoryProcessor.java 74.07% <0%> (+3.7%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a07c32...124dda6. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@marandaneto marandaneto merged commit cbe9dc6 into master Dec 13, 2019
@marandaneto marandaneto deleted the enha/no_dsn_set branch December 13, 2019 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants