Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

SDK final review #183

Merged
merged 9 commits into from
Dec 5, 2019
Merged

SDK final review #183

merged 9 commits into from
Dec 5, 2019

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

final review of the public API.

💡 Motivation and Context

review access modifiers, package structure, etc..

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #183 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
- Coverage     58.08%   58.04%   -0.04%     
- Complexity      551      552       +1     
============================================
  Files            73       72       -1     
  Lines          2617     2617              
  Branches        233      235       +2     
============================================
- Hits           1520     1519       -1     
  Misses          978      978              
- Partials        119      120       +1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/sentry/core/MainEventProcessor.java 63.41% <ø> (ø) 7 <0> (ø) ⬇️
.../main/java/io/sentry/core/protocol/SdkVersion.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...java/io/sentry/core/protocol/SentryStackTrace.java 58.33% <ø> (ø) 4 <0> (ø) ⬇️
...in/java/io/sentry/core/AsyncConnectionFactory.java 81.81% <ø> (+6.81%) 1 <0> (ø) ⬇️
...in/java/io/sentry/core/protocol/SentryRuntime.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../java/io/sentry/core/SentryEnvelopeItemHeader.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...java/io/sentry/core/protocol/SentryStackFrame.java 31.66% <ø> (ø) 13 <0> (ø) ⬇️
...ntry/core/UncaughtExceptionHandlerIntegration.java 77.04% <ø> (ø) 9 <0> (ø) ⬇️
...ain/java/io/sentry/core/protocol/SentryThread.java 73.33% <ø> (ø) 14 <0> (ø) ⬇️
...c/main/java/io/sentry/core/protocol/Mechanism.java 37.93% <ø> (ø) 6 <0> (ø) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db86d06...ea44579. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review December 5, 2019 13:05
@marandaneto marandaneto merged commit 4b34e5f into master Dec 5, 2019
@marandaneto marandaneto deleted the ref/final_review branch December 5, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants