This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
============================================
- Coverage 58.08% 58.04% -0.04%
- Complexity 551 552 +1
============================================
Files 73 72 -1
Lines 2617 2617
Branches 233 235 +2
============================================
- Hits 1520 1519 -1
Misses 978 978
- Partials 119 120 +1
Continue to review full report at Codecov.
|
marandaneto
commented
Dec 4, 2019
marandaneto
commented
Dec 4, 2019
sentry-core/src/main/java/io/sentry/core/transport/AsyncConnection.java
Outdated
Show resolved
Hide resolved
bruno-garcia
reviewed
Dec 4, 2019
sentry-core/src/main/java/io/sentry/core/transport/AsyncConnection.java
Outdated
Show resolved
Hide resolved
bruno-garcia
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
final review of the public API.
💡 Motivation and Context
review access modifiers, package structure, etc..
💚 How did you test it?
📝 Checklist
🔮 Next steps