Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose usage #5

Closed
wants to merge 1 commit into from
Closed

docker-compose usage #5

wants to merge 1 commit into from

Conversation

maguowei
Copy link

@maguowei maguowei commented Aug 5, 2016

  1. variable-substitution
  2. use depends_on, remove links.It seems links no need. ref: https://docs.docker.com/compose/link-env-deprecated/

This change is Reviewable

@maguowei maguowei mentioned this pull request Aug 5, 2016
@Bessonov
Copy link

Bessonov commented Oct 9, 2016

@mattrobenolt

Just merged this PR in master locally and tested. Works for me.

@Bessonov
Copy link

@mattrobenolt
That is not right step. It's OK to write "This docker-compose.yml is meant to be just an example", regardless the repo is described as "Sentry On-Premise setup". Not "Example for Sentry On-Premise setup". It's OK to write "Official bootstrap for running your own Sentry with Docker." and handle it as stepdaughter. But don't provide a setup to run it without modifications and close a PR to get that is very frustrating.

@mattrobenolt
Copy link
Contributor

mattrobenolt commented Nov 11, 2016

docker-compose in general is a very opinionated thing. No docker-compose file is going to work for everyone in every situation. The whole point of this is to help form a foundation, not a one-click install and boom, everything is magic. Our official documentation does not mention docker-compose and we don't recommend it. We don't use it ourselves and I personally have very limited experience with the tool to even begin to give proper recommendations here. Any of the instructions we've provided for native docker can very easily be rolled into you coming up with your own docker-compose file if that's a deployment method you choose.

If you stand back, to me, including docker-compose as a method is equivalent to us also providing a file to run on Mesos/Marathon and Nomad, and instructions for K8, Google Container Service, Carina, etc. It's a method for deployment of the whole stack. Your stack is going to be very different from anyone else's.

@maguowei maguowei deleted the compose-run branch December 1, 2016 06:32
mrijke pushed a commit to mrijke/sentry-onpremise-dokku that referenced this pull request Feb 1, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants