-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CodeQL #618
Setup CodeQL #618
Conversation
Basic setup for CodeQL to scan on PRs targeting master and once a week.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2801 2801
=========================================
Hits 2801 2801 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What is the value of it? |
@beliaev-maksim good questions! Apologies I did not include them in my original PR description. What is the value of it? CodeQL is used to perform security analysis on the codebase. It will use known insecure patterns to identify similar issues in Generally, CodeQL has a low false positive rate. Implementing this tool helps us be good stewards of a relatively popular library package to ensure we are not introducing security vulnerabilities into codebases that depend on us. 🙂 What could be identified and how is it reported? The configuration I'm proposing here uses queries just in the Detections will be reported inline with the potentially vulnerable code on PRs and can be resolved/dismissed directly in the PR. They'll also show up under the Security tab and are visible to those with the necessary permissions. Detections in PRs are visible to anyone. |
considering that the library is used only in testing, then I am not sure what are the vulnerabilities that we can expose if we want to be extra careful, then I would suggest switching it from PR check to on release check. Basically gating test to release do not see a significant need to run it every commit/PR |
Seems fine to me. For context @beliaev-maksim CodeQL is being applied across many of the actively maintained repositories at sentry. |
I do like keeping this in the PR as it closes the feedback loop for contributors. 🙂 I will adjust this PR to exclude the |
@mdtro can you please delete branch? |
Basic setup for CodeQL to scan on PRs targeting master and once a week.