Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overly strict version constraint on urllib3 #657

Closed
damian-gn opened this issue Jul 26, 2023 · 2 comments · Fixed by #659
Closed

Overly strict version constraint on urllib3 #657

damian-gn opened this issue Jul 26, 2023 · 2 comments · Fixed by #659
Labels
Waiting for: Product Owner

Comments

@damian-gn
Copy link

Hello team,

I see that in yesterday's release, you have changed responses to require v2.0 of urllib3 or higher.

This is causing us some dependency conflicts, as our projects use other packages that are still running on the v1.0 branch.

I see that urllib3 v1.0 is still being actively maintaned. Is there a specific reason that responses can no longer use it? I had a look at the discussions in #635 and #636, which discuss compatibility issues with v3.0, but I don't understand why the minimum version was changed here.

Since responses is of course a testing library that we don't install in production, I would opine that it should keep version constraints as loose as possible, so that it accurately tests the version(s) of other packages that would be installed in a production environment. 🙂 Is it possible to get this changed?
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jul 26, 2023
@TheFes TheFes mentioned this issue Jul 27, 2023
Closed
krazos added a commit to krazos/python-forecast.io that referenced this issue Jul 27, 2023
@krazos
Require responses<=0.23.1
073e359 
Require responses<=0.23.1 to resolve dependency conflicts (e.g., with Home Assistant integrations) pending upstream resolution

getsentry/responses#657
home-assistant/core#97248
@krazos krazos mentioned this issue Jul 27, 2023
Closed
@JohnVillalovos JohnVillalovos mentioned this issue Jul 28, 2023
Merged
@JohnVillalovos
Copy link
Contributor

I have proposed PR #659 to allow older versions of urllib3. Not sure if it will be accepted or not.

@JohnVillalovos JohnVillalovos mentioned this issue Jul 28, 2023
Closed
@bearrito
Copy link

Same. This library is used by Moto which I think is the standard test library for AWS services. That library relies on boto. Boto has a hard constraint for urlib < 1.27

@JohnVillalovos JohnVillalovos mentioned this issue Jul 31, 2023
Closed
@mr-cal mr-cal mentioned this issue Jul 31, 2023
Closed
1 task
markstory pushed a commit that referenced this issue Jul 31, 2023
@JohnVillalovos
chore: allow urllib3>=1.25.10 (#659)
c226971 
Allow use of urllib3>=1.25.10. By default it will use urllib3>=2 as
that is the latest version. But this will allow people to pin
urllib3<2 and still use the latest version of requests and responses.

Closes: #657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Waiting for: Product Owner
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: allow urllib3>=1.25.10
chore: allow urllib3>=1.25.10
3 participants
@JohnVillalovos @bearrito @damian-gn