ref(general): Do not default transactions to level error

[jan-auer]

In transactions, the error event level does not make sense. Instead, assign info to transactions.

[untitaker]

we'd have to test locally if this breaks later stages of the pipeline

thanks for taking this, it's been in my personal backlog for a while

[HazAT]

🙏 Thx

[jan-auer]

@untitaker you were right, Sentry unconditionally writes a None tag, which leads to an error in Snuba/clickhouse.

@HazAT I'm defaulting to "info" now.

[untitaker]

Sentry unconditionally writes a None tag, which leads to an error in Snuba/clickhouse.

so if it's about the tag can't we get rid of the tag, or never set it if it's none?

[jan-auer]

so if it's about the tag can't we get rid of the tag, or never set it if it's none?

Yes, but I'd like to do this as a follow-up in Sentry. @untitaker @HazAT would you prefer this to be fixed in Sentry first and then we go back to the prior patch? I personally like that it has a level always, since there's no straight forward way to query in snuba for a missing value.

I forgot to update tests, so depending on your decision I'll either roll back or fix tests.

[untitaker]

there's no straight forward way to query in snuba for a missing value

That I agree with but I don't think we need to solve it this way. Let the discover team figure out how to query for that.

[dashed]

This is great 👍

[dashed]

@jan-auer @untitaker It's a non-issue of whether or not transactions has a level field/tag. We don't rely on this anywhere on the product.

The data team might care about this change as it could impact their work. I'm unsure if they rely on this field/tag to make certain assumptions about transactions events.