Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log(feedback): Add logging to verify produce to ingest-feedback-events #3450

Closed
wants to merge 2 commits into from
+10 −0
Closed

log(feedback): Add logging to verify produce to ingest-feedback-events #3450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5db65cd
Add logging for ingest-feedback-events
aliu39 Apr 17, 2024
6e9badf
Changelog
aliu39 Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
**Internal:**

- Emit negative outcomes in metric stats for metrics. ([#3436](https://github.com/getsentry/relay/pull/3436))
- Temporarily log when messages are produced to ingest-feedback-events (low volume, s4s only). ([#3450](https://github.com/getsentry/relay/pull/3450))

## 24.4.0

Expand Down
9 changes: 9 additions & 0 deletions relay-server/src/services/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,15 @@ impl StoreService {
event_type = message.variant(),
topic = topic_name,
);
if topic_name == "ingest-feedback-events" {
if let KafkaMessage::Event(event_msg) = message {
relay_log::info!("Producing to ingest-feedback-events.\n start_time={}\n event_id={}\n project_id={}",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to pass a kv dict of "extras" like in python?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are our existing metrics not enough?

We shouldn't log in potentially high throughput code (on info level).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, nvm, I just read your description. I'll take a look at the metrics tomorrow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! This log won't be high throughput. Since the topic, consumer, and rollout rate only exist/are set in s4s. And there's little to no feedback sent in s4s, except employees who use the feedback widget on a few sentry pages (ex: performance).

event_msg.start_time,
event_msg.event_id,
event_msg.project_id
);
}
}
}
}

Expand Down
Loading