fix(normalization): Skip validation on renormalization #3214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous normalization PRs run validation from librelay calls. However, some
sentry
tests run full normalization in librelay on partial (i.e. invalid) payloads, and running validation makes plenty of tests fail (see getsentry/sentry#66134).Similarly, many
sentry
tests expect span normalization to never happen. After spending significant time "fixing"* some tests, it'd require me even more time to "fix" the remaining ones as it requires a deeper understanding of other features/codebases. Thus, I'm reintroducingnormalize_spans
to disable span normalization (mostly exclusive time computation) from librelay calls and unblock the librelay release.*Note: "fixing" a test means using data relay outputs from normalization. This doesn't align with other assumptions made in the tests, nor modifications to the event payload in the rest of the event processing pipeline.
Future work
is_renormalize
flag, removing thenormalize_spans
flag.